rananna said:
Added a replacement pull request.
Thanks!! and I see you decided, to store the ANT ID, to not use the flash memory as I do to store the virtual display configurations, and instead use the sd_power_gpregret. The registers used by sd_power_gpregret keep only the value on RAM, even after reset, and only while the system has power only - this means user will have to make the configuration every time it changes the battery, which should not be often but using the flash memory as I did would avoid this. I think that for now we can keep like this and next time we can improve by changing the sd_power_gpregret to flash memory.
I would like you could make some clean before commit, see the following points:
Seems there are files added that are not needed, like UART drivers that are for sure not needed on this project. Please try find not needed, by removing then and build, so this way we will have a project more clean:
Makefile exmaple:
$(SDK_ROOT)/integration/nrfx/legacy/nrf_drv_uart.c \
After do the same on sdk_config.h, like on definitions like this:
#define NRFX_UARTE_ENABLED 1
Please remove this, as they are not used, right?
TSDZ2_REMOTE_FIRMWARE_MAJOR
On main.c, you removed the Copyright, please keep the original and add another line with your nickname or name like
Copyright (C) Casainho, 2020
Copyright (C) rananna, 2020
And why references to a bootloader that does not exist??
timer_button_long_press_bootloader_timeout_handler
m_timer_button_long_press_bootloader_timeout